Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: Fix act errors in SelectFilterPlugin test #21396

Merged
merged 1 commit into from
Sep 9, 2022
Merged

test: Fix act errors in SelectFilterPlugin test #21396

merged 1 commit into from
Sep 9, 2022

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This PR fixes 4 act errors in superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx

TESTING INSTRUCTIONS

  • cd into superset-frontend/src/filters/components/Select
  • run npm run test superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
  • Observe that there are no act errors in the console

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #21396 (fca5e20) into master (08a4cbd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21396      +/-   ##
==========================================
- Coverage   66.58%   66.58%   -0.01%     
==========================================
  Files        1791     1791              
  Lines       68559    68559              
  Branches     7319     7319              
==========================================
- Hits        45650    45647       -3     
- Misses      21020    21022       +2     
- Partials     1889     1890       +1
Flag Coverage Δ
hive 52.97% <ø> (ø)
javascript 52.74% <ø> (-0.01%) ⬇️
mysql 80.83% <ø> (ø)
postgres 80.88% <ø> (ø)
presto 52.87% <ø> (ø)
python 81.36% <ø> (ø)
sqlite 79.43% <ø> (ø)
unit 50.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 85.43% <0.00%> (-1.99%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 584f2e6 into master Sep 9, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/SelectFilterPlugin-act-cleanup branch September 9, 2022 16:26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyndsiWilliams @michael-s-molina @mistercrunch